Skip to content

Possible data leakage in quantum/docs/tutorials /quantum_data.ipynb #828

New issue
New issue
Open
#829
Open
Possible data leakage in quantum/docs/tutorials /quantum_data.ipynb#828
#829
Labels
area/docsConcerns documentation – problems, ideas, requestskind/bug-reportSomething doesn't seem to work
@OkuyanBoga

Description

@OkuyanBoga
OkuyanBoga
opened on Dec 9, 2024

Hi all,

I think there is a possible data leakage in quantum data tutorial in

quantum/docs/tutorials/quantum_data.ipynb

Lines 783 to 790 in 8487280

"S_pqk, V_pqk = get_spectrum(\n",
" tf.reshape(tf.concat([x_train_pqk, x_test_pqk], 0), [-1, len(qubits) * 3]))\n",
"\n",
"S_original, V_original = get_spectrum(\n",
" tf.cast(tf.concat([x_train, x_test], 0), tf.float32), gamma=0.005)\n",
"\n",
"print('Eigenvectors of pqk kernel matrix:', V_pqk)\n",
"print('Eigenvectors of original kernel matrix:', V_original)"

when calculating

quantum/docs/tutorials/quantum_data.ipynb

Line 731 in 8487280

" S, V = tf.linalg.eigh(KC_qs)\n",

train and test data are concatenated in these calculations. I think it is wrong, and those should be separately calculated for each.

Activity

OkuyanBoga
linked a pull request that will close this issue on Dec 9, 2024
mhucka
added
kind/bug-reportSomething doesn't seem to work
area/docsConcerns documentation – problems, ideas, requests
on Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/docsConcerns documentation – problems, ideas, requestskind/bug-reportSomething doesn't seem to work

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @mhucka@OkuyanBoga

      Issue actions
        Possible data leakage in quantum/docs/tutorials /quantum_data.ipynb · Issue #828 · tensorflow/quantum