-
-
Notifications
You must be signed in to change notification settings - Fork 26
feat(abg)!: allow to wire typed outputs to matching typed inputs #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vampire/binding-version-v2
Are you sure you want to change the base?
feat(abg)!: allow to wire typed outputs to matching typed inputs #1624
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ff26830 to
46ca5ad
Compare
|
So far it indeed seems to work just great. |
|
Main remaining problem is probably the naming at https://github.com/typesafegithub/github-workflows-kt/pull/1624/files#diff-76c4a08acf57b6c491c34cc60e6ad7bbc219fbd45dc0dda74550941ecac51200 :-/ |
46ca5ad to
14d4f80
Compare
|
Of course the typing catalog should be polished to have proper output types which it currently does not have. |
14d4f80 to
f4b6351
Compare
3a53468 to
f0429b9
Compare
|
Forgot the job outputs, now they are also typed :-) |
adbea5b to
59626c0
Compare
|
And now |
90360a0 to
09d160e
Compare
d7c1b5d to
f3b7790
Compare
60da5e6 to
53c27b0
Compare
1c80ac5 to
cdeb8d0
Compare
53c27b0 to
c9e8a2f
Compare
cdeb8d0 to
da90471
Compare
c9e8a2f to
d0ef59a
Compare
da90471 to
0937347
Compare
d0ef59a to
1e38b69
Compare
0937347 to
8eabe36
Compare
1e38b69 to
54a0d0e
Compare
8eabe36 to
3cb4b89
Compare
54a0d0e to
0af24c3
Compare
3cb4b89 to
3fc563c
Compare
0af24c3 to
16cb955
Compare
3fc563c to
0dd5cd3
Compare
78db07b to
88a11f6
Compare
454f1fb to
e1487be
Compare
5b5bb0f to
2974c43
Compare
e1487be to
d077e1e
Compare
2974c43 to
481b627
Compare
d077e1e to
3cf8517
Compare
481b627 to
b4d13ce
Compare
3cf8517 to
a32478e
Compare
b4d13ce to
e788dc0
Compare
a32478e to
1239cdc
Compare

Fixes #73
If types of input and output match, you can do
lookupOnlyExpression = cache.outputs.cacheHitIf types do not match for whatever reason, you can still do
lookupOnlyExpression = cache.outputs.cacheHit_Untypedor
or (but deprecated)
lookupOnly_Untyped = cache.outputs.cacheHit.expressionStringIf no type is declared for the output, you can still stuff the
_Untypedone into any expression input likelookupOnlyExpression = cache.outputs.cacheHit_UntypedAd-hoc outputs behave like untyped outputs in that you can stuff it into everywhere