feat: add check of compatibility between library version and binding #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzema12
changed the title
krzema12
commented
Jun 23, 2025
| .builder(name = "getLibraryVersion") | ||
| .addModifiers(KModifier.INTERNAL) | ||
| .returns(String::class) | ||
| .addCode(CodeBlock.of("return \"$libraryVersion\"")) |
There was a problem hiding this comment.
This is the best I could do to pass the version known in build time to the library. I tried with JAR metadata, with no success.
krzema12
commented
Jun 23, 2025
|
|
||
| public abstract val usesString: String | ||
|
|
||
| public open fun isCompatibleWithLibraryVersion(libraryVersion: String): Boolean = true |
There was a problem hiding this comment.
We'll be able to override it in the future releases of the server, so that it runs different logic depending on the version of the server routes.
|
Let me merge so that we start with something. At this stage, we can always adjust the approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to be able to present a nice error message to the user if an incompatible library version is used with a given server routes version. Right now we have only one server routes version, but we're planning to make some breaking changes and expose
/v2/.