Skip to content

Add devcontainer #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add devcontainer #4650

wants to merge 6 commits into from

Conversation

sjev
Copy link

@sjev sjev commented Apr 26, 2025

This pull request introduces a development container setup for the project, including a Dockerfile and configuration file, and updates a script to improve compatibility. The changes aim to streamline the development environment by providing a pre-configured container and addressing minor script improvements.

Development container setup:

  • .devcontainer/Dockerfile: Added a Dockerfile that sets up a development container with Go, Node.js, and pnpm pre-installed. It also creates a non-root user, configures pnpm to avoid long path issues, and sets up the working directory.
  • .devcontainer/devcontainer.json: Added a configuration file for the development container, specifying the Dockerfile, build arguments, port forwarding, and recommended VS Code extensions for Go, Git, and ESLint.

Script improvement:

  • scripts/build.sh: Changed the shell interpreter from sh to bash to improve compatibility and ensure the script exits when any command fails.

@sjev sjev requested a review from boojack as a code owner April 26, 2025 13:02
@sjev sjev closed this Apr 26, 2025
@sjev sjev reopened this Apr 26, 2025
@boojack boojack closed this Jun 17, 2025
@Cadavanaugh
Copy link
Contributor

This is actually a pretty good contribution.

@sjev
Copy link
Author

sjev commented Jul 7, 2025

@boojack I don't mind that you rejected this PR, but could you provide a reason why?

I realized myself that VS Code devcontainer is maybe not an optimal way to facilitate development.
Instead, I already switched to a development docker stack that runs backend with mock database and a frontend server running in separate containers.
Would that be acceptible as a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants