feat(security): Adds last usage date to access tokens #4769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilian-krauss
force-pushed
the
feat/adds-last-usage-to-access-tokens
branch
4 times, most recently
from
5403d50 to
bc8225e
Compare
maximilian-krauss
force-pushed
the
feat/adds-last-usage-to-access-tokens
branch
from
bc8225e to
bf9568c
Compare
maximilian-krauss
force-pushed
the
feat/adds-last-usage-to-access-tokens
branch
from
bf9568c to
67e30b8
Compare
|
@maximilian-krauss We are refactoring the auth logic, including designing a common session that will include information such as the last used time, etc. I'll let you know once it's done. Thanks for the contribution. |
|
Some updates: 
|
|
Nice! thanks for adding it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR adds a last usage date to access tokens, because after login from several browsers and devices, it's hard to tell which access tokens are still being used.
It adds one write after each authenticated API operation which could add stress to the database. I tested with sqlite and mysql without any notable performance issues.
✌️