-
Notifications
You must be signed in to change notification settings - Fork 105
feat(addons): add vanjs-prerender #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8b21d90
to
ca94c4d
Compare
That's a very interesting approach to the problem! Thank you so much for the contribution! Are you open to add this feature as a community add-on? Can be either something in addon directory or in a separate repo. I can add a link to your add-on in |
Actually, I don't have time to maintain the implementation. I created this PR to potentially supersede both minivan and van-plate in order to minimize maintenance costs. |
While I appreciate the novel idea and the elegance of the solution, I'm not sure if this can be a superset of mini-van and van-plate. For instance, mini-van allows you to integrate with server-side DOM library (this is how VanJS website is generated) while van-plate provides an ultra-minimalist SSR solution. |
ca94c4d
to
2b33936
Compare
2b33936
to
88c8153
Compare
@Tao-VanJS, Sorry about the noise. I have changed the change into an addons. Thank you for your suggestion. |
88c8153
to
4e962f6
Compare
4e962f6
to
5ec6b73
Compare
5ec6b73
to
9bd3fec
Compare
Reasons:
minivan
andvan-plate
node
,bun
, anddeno
(On browser,outerHTML
can be used instead)Notes:
test/node/van.prerender.test.js
. (On system, runnode test/node/van.prerender.js
to test)Edit: Update description