Skip to content

feat(addons): add vanjs-prerender #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

binhtran432k
Copy link
Contributor

@binhtran432k binhtran432k commented Jun 11, 2025

Reasons:

  • Alternative to minivan and van-plate
  • Prerender van components on local env like node, bun, and deno (On browser, outerHTML can be used instead)

Notes:

  • Examples can be see through test/node/van.prerender.test.js. (On system, run node test/node/van.prerender.js to test)

Edit: Update description

@binhtran432k binhtran432k force-pushed the feat/prerender branch 2 times, most recently from 8b21d90 to ca94c4d Compare June 11, 2025 07:32
@Tao-VanJS
Copy link
Member

That's a very interesting approach to the problem! Thank you so much for the contribution!

Are you open to add this feature as a community add-on? Can be either something in addon directory or in a separate repo. I can add a link to your add-on in Community Add-ons section.

@binhtran432k
Copy link
Contributor Author

That's a very interesting approach to the problem! Thank you so much for the contribution!

Are you open to add this feature as a community add-on? Can be either something in addon directory or in a separate repo. I can add a link to your add-on in Community Add-ons section.

Actually, I don't have time to maintain the implementation. I created this PR to potentially supersede both minivan and van-plate in order to minimize maintenance costs.

@Tao-VanJS
Copy link
Member

While I appreciate the novel idea and the elegance of the solution, I'm not sure if this can be a superset of mini-van and van-plate. For instance, mini-van allows you to integrate with server-side DOM library (this is how VanJS website is generated) while van-plate provides an ultra-minimalist SSR solution.

@binhtran432k binhtran432k changed the title feat: impl prerender feat(addons): add vanjs-prerender Jun 12, 2025
@binhtran432k
Copy link
Contributor Author

@Tao-VanJS, Sorry about the noise. I have changed the change into an addons. Thank you for your suggestion.

@Tao-VanJS Tao-VanJS merged commit b4a1631 into vanjs-org:main Jun 13, 2025
@Tao-VanJS
Copy link
Member

Tao-VanJS commented Jun 13, 2025

image

🔥🔥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants