Skip to content

feat(ci): improve and remove authorization requirements #23224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 20, 2025

Conversation

thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Jun 17, 2025

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Running actions

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@thomasqueirozb thomasqueirozb changed the title feat(workflows): improve and remove authorization requirements feat(ci): improve and remove authorization requirements Jun 17, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jun 17, 2025

Datadog Report

Branch report: workflows-without-authentication
Commit report: 03e6e4d
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.25s Total Time

@thomasqueirozb thomasqueirozb force-pushed the workflows-without-authentication branch from 0b84533 to a6bd20f Compare June 17, 2025 19:55
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 18, 2025
@thomasqueirozb thomasqueirozb removed the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 18, 2025
@thomasqueirozb thomasqueirozb added no-changelog Changes in this PR do not need user-facing explanations in the release changelog and removed no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Jun 18, 2025
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 20, 2025
@thomasqueirozb thomasqueirozb added the meta: awaiting author Pull requests that are awaiting their author. label Jun 20, 2025
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Jun 20, 2025
@thomasqueirozb thomasqueirozb added the meta: awaiting author Pull requests that are awaiting their author. label Jun 20, 2025
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Jun 20, 2025
@thomasqueirozb thomasqueirozb added meta: awaiting author Pull requests that are awaiting their author. and removed no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Jun 20, 2025
This reverts commit fe418db.
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Jun 20, 2025
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 20, 2025
@thomasqueirozb thomasqueirozb changed the title feat(ci): improve and remove authorization requirements feat(cee-i): improve and remove authorization requirements Jun 20, 2025
@thomasqueirozb thomasqueirozb marked this pull request as ready for review June 20, 2025 17:03
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner June 20, 2025 17:03
@thomasqueirozb thomasqueirozb changed the title feat(cee-i): improve and remove authorization requirements feat(ci): improve and remove authorization requirements Jun 20, 2025
@thomasqueirozb thomasqueirozb requested a review from pront June 20, 2025 17:04
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement.

@thomasqueirozb thomasqueirozb enabled auto-merge June 20, 2025 17:13
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Jun 20, 2025
Merged via the queue into master with commit 6752458 Jun 20, 2025
42 checks passed
@thomasqueirozb thomasqueirozb deleted the workflows-without-authentication branch June 20, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants