Skip to content

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Jun 18, 2025

Summary

Adds an additional field in title of vector top, displaying process uptime in seconds.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Just ran vector top with a running vector instance with api enabled.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References


Sponsored by Quad9

@esensar esensar requested a review from a team as a code owner June 18, 2025 14:27
@thomasqueirozb thomasqueirozb added the meta: awaiting author Pull requests that are awaiting their author. label Jun 18, 2025
@esensar esensar requested a review from thomasqueirozb June 19, 2025 16:18
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Nice! Thank you!

@thomasqueirozb thomasqueirozb enabled auto-merge June 20, 2025 13:43
@thomasqueirozb thomasqueirozb removed the meta: awaiting author Pull requests that are awaiting their author. label Jun 20, 2025
@thomasqueirozb
Copy link
Contributor

thomasqueirozb commented Jun 20, 2025

Please run cargo update -p allocator-api2 and then cargo vdev build licenses. I can't push to your branch unfortunately

auto-merge was automatically disabled June 20, 2025 16:31

Head branch was pushed to by a user without write access

@pront pront enabled auto-merge June 20, 2025 17:27
@pront
Copy link
Member

pront commented Jun 20, 2025

Nice enhancement! Added to the merge.

@pront pront added this pull request to the merge queue Jun 20, 2025
Merged via the queue into vectordotdev:master with commit 01bbc69 Jun 20, 2025
42 checks passed
@esensar esensar deleted the feature/uptime-top branch June 20, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add process uptime in "vector top" view
3 participants