Skip to content

chore(website): fix telemetry types for Sinks #23251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 23, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jun 23, 2025

Summary

Docs improvements.

Based on the implementation of:

fn input(&self) -> Input {

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Ref: #21735

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@pront pront requested review from a team as code owners June 23, 2025 18:59
@pront pront requested a review from thomasqueirozb June 23, 2025 18:59
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jun 23, 2025
Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@pront pront enabled auto-merge June 23, 2025 19:03
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 23, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jun 23, 2025

Datadog Report

Branch report: pront-website-sinks-fix-tele-types
Commit report: 0688fae
Test service: vector

✅ 0 Failed, 10 Passed, 0 Skipped, 25.26s Total Time

Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@pront pront changed the title chore(website): fix sinks telemetry types (part 1) chore(website): fix telemetry types for Sinks Jun 23, 2025
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@pront pront disabled auto-merge June 23, 2025 20:23
@pront pront merged commit 1ee4d2f into master Jun 23, 2025
88 of 92 checks passed
@pront pront deleted the pront-website-sinks-fix-tele-types branch June 23, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants