-
Notifications
You must be signed in to change notification settings - Fork 420
T7537: Bump aws-gwlbtun version to c1fd48b #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
👍 |
pre_build_hook = """ | ||
echo "deb http://deb.debian.org/debian trixie main" | sudo tee /etc/apt/sources.list.d/trixie.list | ||
|
||
sudo bash -c 'cat > /etc/apt/preferences.d/trixie-pin <<EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth the trouble? Are there dramatic improvements in that version, or is the old version going to stop working soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there dramatic improvements in that version, or is the old version going to stop working soon?
@dmbaturin This is AWS requirement https://github.com/aws-samples/aws-gateway-load-balancer-tunnel-handler/blob/c1fd48b7b05879b199ebf1beeeacf0442b3c4ad2/CMakeLists.txt#L7
It cannot be built with different boost
version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth the trouble? Are there dramatic improvements in that version, or is the old version going to stop working soon?
There is some instability with the version we currently have, the nature of which is not clear.
The daemon seems to have changed a lot since the commit we use, and changes include stability fixes: 29 changed files with 26,405 additions and 729 deletions. We recommend finding a way to update the version to keep it synced with the upstream.
fdd3155
to
8f9c490
Compare
I checked the boost version from
diff:
version
|
We can not use the Debian bookworm boost version as newer feature from boost are consumed. This PR builds the boost library but as it's a shared library aws-gwlbtun links to - the library itself must be installed in the target image, too. My recommendation would be to statically link aws-gwlbtun to said boost version. |
When we migrate current to Trixie, this PR will be "vindicated", so to speak. However, we still need to figure out a static linking option for 1.4 and 1.5 LTS branches, that will stay on Bookworm until their EOLs. |
Change summary
Bump aws-gwlbtun version to
c1fd48b
Types of changes
Related Task(s)
Related PR(s)
Checklist: