Skip to content

T7537: Bump aws-gwlbtun version to c1fd48b #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

sever-sever
Copy link
Member

Change summary

Bump aws-gwlbtun version to c1fd48b

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Bump to new version

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever sever-sever requested review from dmbaturin and c-po June 10, 2025 08:13
Copy link

github-actions bot commented Jun 10, 2025

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Jun 10, 2025
pre_build_hook = """
echo "deb http://deb.debian.org/debian trixie main" | sudo tee /etc/apt/sources.list.d/trixie.list

sudo bash -c 'cat > /etc/apt/preferences.d/trixie-pin <<EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth the trouble? Are there dramatic improvements in that version, or is the old version going to stop working soon?

Copy link
Member Author

@sever-sever sever-sever Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there dramatic improvements in that version, or is the old version going to stop working soon?

@dmbaturin This is AWS requirement https://github.com/aws-samples/aws-gateway-load-balancer-tunnel-handler/blob/c1fd48b7b05879b199ebf1beeeacf0442b3c4ad2/CMakeLists.txt#L7

It cannot be built with different boost version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth the trouble? Are there dramatic improvements in that version, or is the old version going to stop working soon?

There is some instability with the version we currently have, the nature of which is not clear.

The daemon seems to have changed a lot since the commit we use, and changes include stability fixes: 29 changed files with 26,405 additions and 729 deletions. We recommend finding a way to update the version to keep it synced with the upstream.

@sever-sever sever-sever force-pushed the T7537 branch 3 times, most recently from fdd3155 to 8f9c490 Compare June 11, 2025 01:24
@sever-sever
Copy link
Member Author

sever-sever commented Jun 12, 2025

I checked the boost version from bookworm and it does not build

make[3]: Leaving directory '/vyos/work/T7537/vyos-build/scripts/package-build/aws-gwlbtun/aws-gwlbtun/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:86: CMakeFiles/gwlbtun.dir/all] Error 2
make[2]: Leaving directory '/vyos/work/T7537/vyos-build/scripts/package-build/aws-gwlbtun/aws-gwlbtun/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:94: all] Error 2
make[1]: Leaving directory '/vyos/work/T7537/vyos-build/scripts/package-build/aws-gwlbtun/aws-gwlbtun/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j12 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:6: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -b failed
Failed to build package aws-gwlbtun: 

diff:

vyos_bld@3867c1c7f703:/vyos/work/T7537/vyos-build/scripts/package-build/aws-gwlbtun$ cat aws-gwlbtun/CMakeLists.txt  | grep REQ
find_package(Boost 1.74 REQUIRED)

version

vyos_bld@3867c1c7f703:/vyos/work/T7537/vyos-build/scripts/package-build/aws-gwlbtun$ 
vyos_bld@3867c1c7f703:/vyos/work/T7537/vyos-build/scripts/package-build/aws-gwlbtun$ sudo dpkg -l | grep boost
ii  libboost-all-dev                       1.74.0.3    

@c-po
Copy link
Member

c-po commented Jun 15, 2025

We can not use the Debian bookworm boost version as newer feature from boost are consumed. This PR builds the boost library but as it's a shared library aws-gwlbtun links to - the library itself must be installed in the target image, too.

My recommendation would be to statically link aws-gwlbtun to said boost version.

@dmbaturin
Copy link
Member

When we migrate current to Trixie, this PR will be "vindicated", so to speak. However, we still need to figure out a static linking option for 1.4 and 1.5 LTS branches, that will stay on Bookworm until their EOLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

4 participants