fix: do not split main.py on 'def main'

[pyranota]

doesn't work well in edge cases:

@schedule(
    bla=True
)
def main(x: str):
    return x

error_message = """
Please ensure you have defined main(username, password) correctly.
The function def main( should be at the end.
"""

def main(x: str):
    return x

---

Important

Remove splitting on 'def main(' in parse_code_for_imports to handle edge cases with decorators and multiline strings.

• Behavior:
  • Removes splitting of code on 'def main(' in parse_code_for_imports in lib.rs.
  • Handles code as a whole to avoid issues with decorators and multiline strings.
• Misc:
  • Minor formatting change in parse_python_imports_inner.

^{This description was created by for 8431e75. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 8431e75 in 1 minute and 11 seconds. Click for details.

• Reviewed 32 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. backend/parsers/windmill-parser-py-imports/src/lib.rs:28

• Draft comment:
  Removed constant DEF_MAIN and the splitting on it in parse_code_for_imports. This resolves the edge case where a decorated or multiple-appearance of 'def main' would cause incorrect truncation.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. backend/parsers/windmill-parser-py-imports/src/lib.rs:378

• Draft comment:
  Indentation adjustment for map_err(to_anyhow) appears to be solely formatting. Confirm consistency with project style guidelines.
• Reason this comment was not posted:
  Confidence changes required: 20% <= threshold 50% None

Workflow ID: wflow_BZjNNGAAisVdryhI

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	8431e75
Status:	✅  Deploy successful!
Preview URL:	https://f471fd6d.windmill.pages.dev
Branch Preview URL:	https://fix-dont-split-python-on-def.windmill.pages.dev

View logs