Skip to content

fix: rendering of datatable in workers page #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dieriba
Copy link
Contributor

@dieriba dieriba commented Jun 12, 2025

Important

Add padding adjustment to a button in +page.svelte.

  • UI Changes:
    • Add btnClasses="pl-0" to a Button element in +page.svelte to adjust padding.

This description was created by Ellipsis for e4997dc. You can customize this summary. It will automatically update as commits are pushed.

@dieriba dieriba marked this pull request as ready for review June 12, 2025 06:22
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to e4997dc in 39 seconds. Click for details.
  • Reviewed 21 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/routes/(root)/(logged)/workers/+page.svelte:593
  • Draft comment:
    Extra whitespace added after 'last' attribute. Verify if this change is intentional for rendering consistency.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. frontend/src/routes/(root)/(logged)/workers/+page.svelte:721
  • Draft comment:
    Added btnClasses="pl-0" to the Button. Confirm that this styling change aligns with the intended design and doesn’t conflict with other button styles.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_C0puZryt4NeS0uew

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4997dc
Status: ✅  Deploy successful!
Preview URL: https://896c49f2.windmill.pages.dev
Branch Preview URL: https://dieri-fix-agent-worker-styli.windmill.pages.dev

View logs

@dieriba dieriba changed the title fix rendering fix: rendering on datatable of workers page Jun 12, 2025
@dieriba dieriba changed the title fix: rendering on datatable of workers page fix: rendering of cell Live Shell in datatable of workers page Jun 12, 2025
@dieriba dieriba changed the title fix: rendering of cell Live Shell in datatable of workers page fix: rendering of datatable in workers page Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant