Skip to content

Optimize accept all button display in AI chat #6001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Optimize accept all button display in AI chat #6001

wants to merge 1 commit into from

Conversation

claude[bot]
Copy link
Contributor

@claude claude bot commented Jun 19, 2025

Summary

  • Simplifies the logic for showing/hiding apply and accept all buttons in AI chat code suggestions
  • Replaces complex code comparison logic with simpler state-based approach
  • Hides buttons after "accept all" is clicked and shows them again when editor code changes

Changes

  • AIChatManager.svelte.ts: Added acceptAllClicked state and updated canApplyCode logic
  • CodeDisplay.svelte: Removed code comparison from button visibility condition
  • monaco-adapter.ts: Added state management for accept all clicks and editor changes

Behavior Changes

  • Before: Buttons showed when canApplyCode && code !== scriptEditorOptions?.code
  • After: Buttons hide after clicking "accept all" and reappear when editor content changes

Test Plan

  • Verify apply/accept all buttons appear for code suggestions in AI chat
  • Click "accept all" and verify buttons are hidden
  • Manually edit editor content and verify buttons reappear
  • Test with multiple code blocks in chat conversation

Fixes #5999

🤖 Generated with Claude Code

@claude @rubenfiszel
feat: optimize accept all button display in AI chat
d2b17a2 
- Add acceptAllClicked state to AIChatManager to track when accept all was clicked
- Update canApplyCode logic to hide buttons after accept all is clicked
- Simplify CodeDisplay button visibility to remove code comparison logic
- Add editor change listener to reset state when user manually edits code
- Show buttons again when editor content changes as requested

Addresses issue #5999

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Ruben Fiszel <rubenfiszel@users.noreply.github.com>
@claude claude bot mentioned this pull request Jun 19, 2025
Open
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: d2b17a2
Status: ✅  Deploy successful!
Preview URL: https://3b2d1df4.windmill.pages.dev
Branch Preview URL: https://claude-issue-5999-20250619-1.windmill.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenfiszel rubenfiszel Awaiting requested review from rubenfiszel rubenfiszel will be requested when the pull request is marked ready for review rubenfiszel is a code owner

@HugoCasa HugoCasa Awaiting requested review from HugoCasa HugoCasa will be requested when the pull request is marked ready for review HugoCasa is a code owner

@alpetric alpetric Awaiting requested review from alpetric alpetric will be requested when the pull request is marked ready for review alpetric is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize accept all button display in ai chat
0 participants