Skip to content

language_models: Fix Mistral #33640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

language_models: Fix Mistral #33640

wants to merge 1 commit into from

Conversation

sviande
Copy link

@sviande sviande commented Jun 30, 2025

Closes #32675

The previous implementation add tools messages at the end of the queue, the new implementation keep the history order

Release Notes:

@bennetbo @sviande
agent: Use standardized MCP configuration format in settings (zed-ind…
c536457 
…ustries#33539)

Changes our MCP settings from:

```json
{
  "context_servers": {
    "some-mcp-server": {
      "source": "custom",
      "command": {
        "path": "npx",
        "args": [
          "-y",
          "@supabase/mcp-server-supabase@latest",
          "--read-only",
          "--project-ref=<project-ref>",
        ],
        "env": {
          "SUPABASE_ACCESS_TOKEN": "<personal-access-token>",
        },
      },
    },
  },
}

```

to:
```json
{
  "context_servers": {
    "some-mcp-server": {
      "source": "custom",
      "command": "npx",
      "args": [
        "-y",
        "@supabase/mcp-server-supabase@latest",
        "--read-only",
        "--project-ref=<project-ref>",
      ],
      "env": {
        "SUPABASE_ACCESS_TOKEN": "<personal-access-token>",
      },
    },
  },
}
```

Which seems to be somewhat of a standard now (VSCode, Cursor, Windsurf,
...)

Release Notes:

- agent: Use standardised format for configuring MCP Servers
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 30, 2025
@sviande sviande mentioned this pull request Jun 30, 2025
Open
@SomeoneToIgnore SomeoneToIgnore added the ai Improvement related to Agent Panel, Edit Prediction, Copilot, or other AI features label Jun 30, 2025
@maxdeviant maxdeviant marked this pull request as draft June 30, 2025 11:16
@maxdeviant maxdeviant changed the title [WIP] Language_models: fix mistral #32675 language_models: Fix Mistral Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ai Improvement related to Agent Panel, Edit Prediction, Copilot, or other AI features cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mistral: 400 Error: "Unexpected role 'tool' after role 'user'" or "Not the same number of function calls and responses"
3 participants
@sviande @SomeoneToIgnore @bennetbo