rename: Add and document errors caused by circular loops #24159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gooncreeper
force-pushed
the
rename-circular-error
branch
from
bddeea1 to
5f7301b
Compare
squeek502
reviewed
Jun 12, 2025
squeek502
reviewed
Jun 12, 2025
gooncreeper
force-pushed
the
rename-circular-error
branch
from
5f7301b to
e8f1be1
Compare
gooncreeper
force-pushed
the
rename-circular-error
branch
from
e8f1be1 to
539b31d
Compare
gooncreeper
changed the title
On POSIX systems, EINVAL is used to indicate circular loops; additionally, corresponding with the use of the error in other filesystem syscalls, it is used to indicate bad file names. Based on empirical testing on Windows 10, SHARING_VIOLATION is used to indicate a circular loop. On Windows 11, INVALID_PARAMATER is used instead.
gooncreeper
force-pushed
the
rename-circular-error
branch
from
539b31d to
370c026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On POSIX systems, EINVAL is used to indicate circular loops;
additionally, corresponding with the use of the error in other
filesystem syscalls, it is used to indicate bad file names.
Based on empirical testing on Windows 10, SHARING_VIOLATION is
used to indicate a circular loop. On Windows 11, INVALID_PARAMATER
is used instead.