Welcome: Make it possible to remove steps

[obenland]

Makes it possible to remove an onboarding step by removing the action that adds it, and the step tracking still keeping track correctly.

Proposed changes:

• Adds tests.
• Makes sure a step is registered before counting it.

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

• In a snippets plugin, or any other place, remove an onboarding step by removing the action that adds it. For example \remove_action( 'activitypub_onboarding_steps', array( Activitypub\WP_Admin\Welcome_Fields::class, 'render_step_profile_mode' ), 40 );
• Visit Settings > Activitypub and complete the remaining steps.
• Make sure the count and next-item highlight work as expected.

Changelog entry

• Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message

Step completion tracking in the Welcome tab now even works when the number of steps gets reduced.

[Copilot]

Pull Request Overview

Enables dynamic removal of onboarding steps by checking for their existence before counting or selecting them, and adds tests to verify this behavior.

• Guard step logic in completion and next-step methods with has_step to skip removed steps
• Introduce has_step helper to detect hooked steps
• Add unit tests covering removal scenarios for completed, total, and next steps

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tests/includes/wp-admin/class-test-welcome-fields.php	New tests for get_completed_steps_count, get_total_steps_count, and get_next_incomplete_step with step removal scenarios
includes/wp-admin/class-welcome-fields.php	Wrapped existing step checks with has_step, and added the has_step helper method

Comments suppressed due to low confidence (1)

tests/includes/wp-admin/class-test-welcome-fields.php:113

• [nitpick] Method names prefixed with double underscores are typically reserved for PHP magic methods; consider renaming __return_option_zero to something like return_option_zero to avoid confusion.

public function __return_option_zero() { // phpcs:ignore PHPCompatibility.FunctionNameRestrictions.ReservedFunctionNames.MethodDoubleUnderscore