Welcome Page: Fix missing CSS when used as fallback

[pfefferle]

While testing #1802 and #1806 I experienced a bug, where the CSS was not shown for the Welcome page when used as fallback.

When the plugin is configured to use only Actors (no blog user), the plugin loads the Welcome page as fallback if you try to load /wp-admin/options-general.php?page=activitypub&tab=blog-profile (same with other potentially deactivated settings pages). In this case the tab query param is blog-profile but it loads the welcome screen and because we have this check in place:

if ( 'welcome' === ( isset( $_GET['tab'] ) ? \sanitize_key( $_GET['tab'] ) : 'welcome' ) )

the welcome screen will be loaded without CSS.

Proposed changes:

• Check for loaded template file instead of tab, to show the CSS

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

• Checkout trunk
• Change User-Mode to "Actors only"
• Load /wp-admin/options-general.php?page=activitypub&tab=blog-profile
• You will see the page with the missing CSS
• Checkout this PR and re-do all the steps above

Changelog entry

• Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message

The Welcome screen now loads with proper styling when shown as a fallback.

[obenland]

Oh, nice catch! I saw that once in my testing and couldn't figure out what happened.

How would you feel about enqueueing it from the template itself, like we do with embeds? Could help avoid a bit of logic

[pfefferle]

no real preference, so happy to move it to the template.

[Copilot]

Pull Request Overview

This PR fixes the issue of missing CSS on the Welcome page when it is used as a fallback by changing the CSS enqueue behavior. Key changes include:

• Enqueueing the Welcome page CSS directly in the template.
• Removing the redundant CSS enqueue action in the admin welcome fields.
• Adding tests for polyfill functions and updating the changelog.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/includes/class-test-compat.php	Added tests for new polyfill functions
templates/welcome.php	Enqueued CSS directly in the template to fix the fallback styling issue
includes/wp-admin/class-welcome-fields.php	Removed redundant enqueue_styles hook for the Welcome page
includes/compat.php	Added polyfill for str_ends_with function
.github/changelog/1820-from-description	Created changelog entry for the bug fix

[pfefferle]

@obenland done

[obenland]

Do you want to keep the str_ends_with() stuff? It doesn't seem to be needed any longer

[pfefferle]

I would love to keep it and simplify other parts of the code to use that instead!