Do not store activitypub_max_image_attachments if it uses the default value

[pfefferle]

Do not store the activitypub_max_image_attachments Post-Meta, if it is the same as the default, to not spam the DB.

Proposed changes:

• Checks if the activitypub_max_image_attachments setting from the block editor has the same value as the default, and remove it if so.

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

• See unittest

Changelog entry

• Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message

The image attachment setting is no longer saved to the database if it matches the default value.

[Copilot]

Pull Request Overview

This PR prevents storing the activitypub_max_image_attachments post meta when it matches the default setting, reducing unnecessary database entries.
Key changes:

• Updated updated_postmeta to delete meta when it equals the default option
• Added unit tests for this behavior
• Created a changelog entry for the change

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
tests/includes/class-test-activitypub.php	Adds test_updated_postmeta to verify default-value meta is not persisted and custom values are
includes/class-activitypub.php	Extends updated_postmeta to delete the max-image-attachments meta if it equals the default
.github/changelog/1821-from-description	Adds a patch-level changelog entry detailing the behavior change

Comments suppressed due to low confidence (1)

includes/class-activitypub.php:692

• [nitpick] Update the docblock above updated_postmeta to mention that this method also removes the activitypub_max_image_attachments meta when it matches the default.

public static function updated_postmeta( $meta_id, $object_id, $meta_key, $meta_value ) {

[obenland]

This should be good to go as-is.

The function doc is currently specific to activitypub_content_visibility, so that could be generalized, but I'm not sure I'd consider it a blocker.

Potential follow-ups:

• We could consider giving activitypub_content_warning a similar treatment.
• I don't know if it's possible to move this to the update_post_metadata hook and avoid the step of updating the value?
• Should all of this also happen when a meta value gets added?

[pfefferle]

I will work on a follow up! I think it should work for both!