Signature: Double-knock on any 400 response #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR broadens the "double knock" retry logic to apply on any 4xx HTTP response, not just 401 Unauthorized.
- Extracts the response code into a variable.
- Changes the condition from strictly 401 to any 400–499 status.
- Continues to remove signature headers and mark hosts unsupported on retry.
Comments suppressed due to low confidence (2)
includes/class-signature.php:206
- The comment above still references a 401 status; please update it to mention retrying on any 4xx response to match the new logic.
// Remove this filter to prevent infinite recursion.
includes/class-signature.php:210
- Consider adding or updating unit tests to cover the new retry behavior for various 4xx status codes (e.g., 404, 429) to ensure this path is exercised.
if ( 400 <= $response_code && 500 > $response_code ) {
obenland
added
the
Skip Changelog
pfefferle
reviewed
Jun 30, 2025
obenland
changed the title
obenland
commented
Jul 1, 2025
includes/class-signature.php
Outdated
| $response_code = \wp_remote_retrieve_response_code( $response ); | ||
|
|
||
| // Fall back to Draft Cavage signature for any 4xx responses. | ||
| if ( 400 <= $response_code && $response_code < 500 ) { |
There was a problem hiding this comment.
@pfefferle Are we being to broad with this? So far I've only observed 401s and 400s. And a 500 for Ghost, but I think that may be a one-off.
There was a problem hiding this comment.
I think I am fine with checking all 4xx codes for now. Otherwise we could limit to 400 and 401 and start logging error codes!?
pfefferle
reviewed
Jul 2, 2025
Co-authored-by: Matthias Pfefferle <pfefferle@users.noreply.github.com>
pfefferle
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemmy processes content digest first and fails it with a
400response. We'll need to expand the status code check to also send a second knock in that case.Follow-up to #1858.
Proposed changes: