Skip to content

Follow: Set local user as actor in Accept activities #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

obenland
Copy link
Member

@obenland obenland commented Jul 1, 2025

Follow up to #1759.

I noticed Accept activities getting rejected by Ghost, with the message The signer and the actor do not match.. This PR restores setting the actor for the Accept activity to the local user that's being followed.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Apply this PR to a test site that's accessible from the internet.
  • From another instance, send a new Follow request to your test site.
  • Make sure the Follow is successful.

@obenland obenland requested a review from pfefferle July 1, 2025 15:03
@obenland obenland self-assigned this Jul 1, 2025
@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 15:03
@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Jul 1, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the earlier change to the actor property in the Accept activity and enhances the unit test to verify that the local user is correctly set as the activity’s actor.

  • Restores original behavior of setting the actor field to the local user ID in queue_accept
  • Updates test_queue_accept to use the Actors and Followers collections, stub remote metadata, and assert on the local actor
  • Adds cleanup for the remote metadata filter

@pfefferle
Copy link
Member

We should have a patch release for that one!!!

Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫣

@obenland obenland merged commit 769d9d7 into trunk Jul 2, 2025
11 checks passed
@obenland obenland deleted the fix/accept-actor branch July 2, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants