-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Have Linux CI for casks #19485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Homebrew/brew CI or Homebrew/homebrew-cask CI? I assume the latter (in which case it should probably be in that repo). I think it would be good to do more manual testing first e.g. try to install all non-conflicting casks on Linux and see what works/breaks. Introducing a 🔴 to most homebrew-cask PRs seems like a 👎🏻. |
I'd say both actually.
I thought about it, but the runner selection logic actually lives here in the repo
Cask CI actually only runs on a subset of the supported versions so if no Linux support is declared it won't test on Linux (if we keep the same logic) |
We already have Homebrew/brew CI for this, no?
Ok. I guess my experience so far is that there's more casks supposedly supported on Linux than will actually install on Linux without errors and this needs addressed first. Alternatively, we go back to the model of explicitly adding some DSL to everything known to actually work on Linux (at least temporarily) |
The tests run on Linux, but things like |
Not sure which job this refers to? |
Looks like I mixed a couple of them up. There is "test default formula" on various platforms, but no casks. There is only https://github.com/Homebrew/brew/actions/runs/13862934537/job/38795614991 on macOS for audits |
@SMillerDev Once |
Verification
brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.Provide a detailed description of the proposed feature
Now that linux support is added to casks, we should also set up CI for casks.
What is the motivation for the feature?
With CI, we find bugs before they reach people.
How will the feature be relevant to at least 90% of Homebrew users?
With CI, we find bugs before they reach people.
What alternatives to the feature have been considered?
Removing linux support for casks again?
The text was updated successfully, but these errors were encountered: