Skip to content

Have Linux CI for casks #19485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
SMillerDev opened this issue Mar 13, 2025 · 7 comments
Open
1 task done

Have Linux CI for casks #19485

SMillerDev opened this issue Mar 13, 2025 · 7 comments
Labels
help wanted We want help addressing this

Comments

@SMillerDev
Copy link
Member

Verification

Provide a detailed description of the proposed feature

Now that linux support is added to casks, we should also set up CI for casks.

What is the motivation for the feature?

With CI, we find bugs before they reach people.

How will the feature be relevant to at least 90% of Homebrew users?

With CI, we find bugs before they reach people.

What alternatives to the feature have been considered?

Removing linux support for casks again?

@SMillerDev SMillerDev added the help wanted We want help addressing this label Mar 13, 2025
@MikeMcQuaid
Copy link
Member

Now that linux support is added to casks, we should also set up CI for casks.

Homebrew/brew CI or Homebrew/homebrew-cask CI?

I assume the latter (in which case it should probably be in that repo).

I think it would be good to do more manual testing first e.g. try to install all non-conflicting casks on Linux and see what works/breaks. Introducing a 🔴 to most homebrew-cask PRs seems like a 👎🏻.

@SMillerDev
Copy link
Member Author

Homebrew/brew CI or Homebrew/homebrew-cask CI?

I'd say both actually.

I assume the latter (in which case it should probably be in that repo).

I thought about it, but the runner selection logic actually lives here in the repo

I think it would be good to do more manual testing first e.g. try to install all non-conflicting casks on Linux and see what works/breaks. Introducing a 🔴 to most homebrew-cask PRs seems like a 👎🏻.

Cask CI actually only runs on a subset of the supported versions so if no Linux support is declared it won't test on Linux (if we keep the same logic)

@MikeMcQuaid
Copy link
Member

I'd say both actually.

We already have Homebrew/brew CI for this, no?

Cask CI actually only runs on a subset of the supported versions so if no Linux support is declared it won't test on Linux (if we keep the same logic)

Ok. I guess my experience so far is that there's more casks supposedly supported on Linux than will actually install on Linux without errors and this needs addressed first.

Alternatively, we go back to the model of explicitly adding some DSL to everything known to actually work on Linux (at least temporarily)

@SMillerDev
Copy link
Member Author

We already have Homebrew/brew CI for this, no?

The tests run on Linux, but things like test cask run on macOS only AFAIK.

@MikeMcQuaid
Copy link
Member

The tests run on Linux, but things like test cask run on macOS only AFAIK.

Not sure which job this refers to?

@SMillerDev
Copy link
Member Author

Looks like I mixed a couple of them up. There is "test default formula" on various platforms, but no casks. There is only https://github.com/Homebrew/brew/actions/runs/13862934537/job/38795614991 on macOS for audits

@MikeMcQuaid
Copy link
Member

Looks like I mixed a couple of them up. There is "test default formula" on various platforms, but no casks. There is only Homebrew/brew/actions/runs/13862934537/job/38795614991 on macOS for audits

@SMillerDev Once brew test-bot sufficiently supports casks: I think adding a test default cask job would make sense. For that to be useful, though, the Cask CI would have to be mostly moved over to use brew test-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We want help addressing this
Projects
None yet
Development

No branches or pull requests

2 participants