otf2bdf 3.1_p1 #221922
Merged
otf2bdf 3.1_p1 #221922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
autosquash
samford
added
the
CI-no-fail-fast
samford
force-pushed
the
otf2bdf-update-stable
branch
from
0c0dc58 to
909c47f
Compare
I haven't been able to identify a way of finding version information for `otf2bdf` from the current `stable` source, so I left it alone for some time. We recently discussed checking the GitHub repository's tags but this doesn't align with the `stable` source. The software hasn't been meaningfully updated since 2015 but the GitHub repository contains a few commits from 2021. The `3.1` tag is for the code as it was in 2015 but there's also a `3.1_p1` tag that includes the 2021 changes (the tags were created out of order, so it looks like `3.1` is newer than `3.1_p1`). This updates the formula to `3.1_p1`, using the tag tarball from GitHub, and adds a `livecheck` block that checks the Git tags. The build was failing on Linux CI with an `ft2build.h` error, due to `otf2bdf.c` using `#include <ft2build.h>` instead of `<freetype2/ft2build.h>`, but the `CFLAGS` snippet from other formulae appears to resolve the error here as well. Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
samford
force-pushed
the
otf2bdf-update-stable
branch
from
909c47f to
30800b1
Compare
github-actions
bot
removed
the
autosquash
samford
removed
the
CI-no-fail-fast
SMillerDev
approved these changes
May 1, 2025
|
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I haven't been able to identify a way of finding version information for
otf2bdffrom the currentstablesource, so I left it alone for some time. We recently discussed checking the GitHub repository's tags but this doesn't align with thestablesource.The software hasn't been meaningfully updated since 2015 but the GitHub repository contains a few commits from 2021. The
3.1tag is for the code as it was in 2015 but there's also a3.1_p1tag that includes the 2021 changes (the tags were created out of order, so it looks like3.1is newer than3.1_p1).This updates the formula to
3.1_p1, using the tag tarball from GitHub, and adds alivecheckblock that checks the Git tags. The build was failing on Linux CI with anft2build.herror, due tootf2bdf.cusing#include <ft2build.h>instead of<freetype2/ft2build.h>, but theCFLAGSsnippet from other formulae appears to resolve the error here as well.