Skip to content

csound: fix building with Ableton Link #223412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

nwhetsell
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR updates the Ableton Link resource to the latest commit, which doesn’t use functions that were removed in ASIO v1.33. (I tried to apply that commit as a patch, but the patch didn’t apply cleanly.)

While we’re at it, also

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue labels May 14, 2025
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 14, 2025
@nwhetsell
Copy link
Contributor Author

I’ve also added a patch for an apparently incorrect member variable name. The code that’s causing the build failure seems to have been around since 2021; I’m very unsure how this was ever working. I also don’t know if a patch is the best way to fix this.

@nwhetsell
Copy link
Contributor Author

It looks like the build failure was due to an intermittent issue with downloading from GitHub. (The resource that failed to download is a patch that was added to the formula in 2022.)

@calvinit
Copy link

calvinit commented May 23, 2025

Just wondering — once it’s merged, would that help with the CI deps check failing on #212057?

@nwhetsell
Copy link
Contributor Author

It should, the Csound build in openjdk errors with Ableton Link, and that error is what this PR is intended to address.

@SMillerDev
Copy link
Member

Thanks @nwhetsell ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@SMillerDev SMillerDev added this pull request to the merge queue May 23, 2025
Merged via the queue into Homebrew:master with commit e279f53 May 23, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. java Java use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants