-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
csound: fix building with Ableton Link #223412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I’ve also added a patch for an apparently incorrect member variable name. The code that’s causing the build failure seems to have been around since 2021; I’m very unsure how this was ever working. I also don’t know if a patch is the best way to fix this. |
It looks like the build failure was due to an intermittent issue with downloading from GitHub. (The resource that failed to download is a patch that was added to the formula in 2022.) |
Just wondering — once it’s merged, would that help with the CI deps check failing on #212057? |
It should, the Csound build in |
Thanks @nwhetsell ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉 |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This PR updates the Ableton Link resource to the latest commit, which doesn’t use functions that were removed in ASIO v1.33. (I tried to apply that commit as a patch, but the patch didn’t apply cleanly.)
While we’re at it, also
HEAD
branch todevelop
(so that the formula passesbrew audit --strict --online
).