Skip to content

Intel Linux bottle cache not working due to ARM Linux #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cho-m opened this issue Apr 3, 2025 · 4 comments
Open

Intel Linux bottle cache not working due to ARM Linux #1456

cho-m opened this issue Apr 3, 2025 · 4 comments

Comments

@cho-m
Copy link
Member

cho-m commented Apr 3, 2025

On CI re-runs with both ARM and Intel Linux, the Intel runner may download the cache for ARM, e.g. linux-self-hosted-1 downloaded bottles_ubuntu-22.04-arm at https://github.com/Homebrew/homebrew-core/actions/runs/14160991497/job/39666467650?pr=206362#step:4:36

==> Running Formulae#run!
==> Downloading artifacts matching pattern bottles{,_{linux,ubuntu}*} from 0edf95eb48a970e395721c19fbea24a897942a99
==> Downloading artifact bottles_ubuntu-22.04-arm from 0edf95eb48a970e395721c19fbea24a897942a99

bottle_specifier = if OS.linux?
"{linux,ubuntu}"
else
"{macos-#{MacOS.version},#{MacOS.version}-#{Hardware::CPU.arch}}"
end
download_artifacts_from_previous_run!("bottles{,_#{bottle_specifier}*}", dry_run: args.dry_run?)


A workaround could be to modify the pattern match to check for the arm suffix though checking for negation is not that clean.

@cho-m
Copy link
Member Author

cho-m commented Apr 12, 2025

It did work in https://github.com/Homebrew/homebrew-core/actions/runs/14421742385/job/40445241798?pr=217231#step:4:36 though could improve to avoid downloading arm bottles on x86_64

==> Downloading artifacts matching pattern bottles{,_{linux,ubuntu}*} from 93da0bd65964c10b68fdfa2ada49e4a15e8d9ba8
==> Downloading artifact bottles_ubuntu-22.04-arm from 93da0bd65964c10b68fdfa2ada49e4a15e8d9ba8
==> Downloading https://api.github.com/repos/Homebrew/homebrew-core/actions/artifacts/2932462196/zip
==> Downloading artifact bottles_linux-self-hosted-1 from 93da0bd65964c10b68fdfa2ada49e4a15e8d9ba8
==> Downloading https://api.github.com/repos/Homebrew/homebrew-core/actions/artifacts/2933152809/zip
==> Running Formulae#formula!(boost)

Copy link

github-actions bot commented May 4, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label May 4, 2025
@MikeMcQuaid
Copy link
Member

CC @carlocab or @Bo98 who may have ideas here

@github-actions github-actions bot removed the stale label May 6, 2025
@carlocab
Copy link
Member

carlocab commented May 6, 2025

We probably should clean up the artifact names so that it's something like bottles_linux-x86_64 and bottles_linux-arm64 so that we don't have to try to match specifically against ubuntu-22.04-arm to include/exclude bottle artifacts.

I don't see how this breaks the bottle cache, though -- at worst it should just be introducing unnecessary downloads, instead of preventing bottles from being cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants