-
-
Notifications
You must be signed in to change notification settings - Fork 33
Newell - fix email issues #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmunityGlobal/HGNRest into newell-fix-multiple-issues
one-community
approved these changes
May 30, 2025
one-community
added a commit
that referenced
this pull request
May 30, 2025
* fix(email): resolve sendEmailWithAcknowledgment promise correctly * docs(email): add JSDoc to emailSender for improved type hints and clarity * docs(email): add JSDoc to emailSender for improved type hints and clarity * fix(transaction): revert transaction edits for local debugging Co-authored-by: Ankuriboh <183397864+Ankuriboh@users.noreply.github.com>
one-community
added a commit
that referenced
this pull request
Jun 1, 2025
* Newell - fix email issues (#1430) * fix(email): resolve sendEmailWithAcknowledgment promise correctly * docs(email): add JSDoc to emailSender for improved type hints and clarity * docs(email): add JSDoc to emailSender for improved type hints and clarity * fix(transaction): revert transaction edits for local debugging * Zhifan - hotfix not seeing hours logged in weekly summaries report page (#1432) * fixed logic for returning time info * fixed three weeks age tab showed no hours --------- Co-authored-by: Ankuriboh <183397864+Ankuriboh@users.noreply.github.com> Co-authored-by: Zhifan Jia <127051168+mashpotato9@users.noreply.github.com>
one-community
added a commit
that referenced
this pull request
Jun 7, 2025
* Newell - fix email issues (#1430) * fix(email): resolve sendEmailWithAcknowledgment promise correctly * docs(email): add JSDoc to emailSender for improved type hints and clarity * docs(email): add JSDoc to emailSender for improved type hints and clarity * fix(transaction): revert transaction edits for local debugging * Zhifan - hotfix not seeing hours logged in weekly summaries report page (#1432) * fixed logic for returning time info * fixed three weeks age tab showed no hours * Newell - move cc recipients to bcc for privacy (#1435) fix(email): move cc recipients to bcc for privacy * Strallia - Hours completed backend data (#1437) feat: get data for tangible hours percentages * Newell - add Jae to CC recipients in emailSender (#1441) feat(email): add Jae to CC recipients in emailSender * Rishitha noshow visualization metrics (#1227) * no show viz * fix url * resolve conflicts * resolve conflicts --------- Co-authored-by: Ankuriboh <183397864+Ankuriboh@users.noreply.github.com> Co-authored-by: Zhifan Jia <127051168+mashpotato9@users.noreply.github.com> Co-authored-by: Strallia Chao <134454347+strallia@users.noreply.github.com> Co-authored-by: RishithaMamidala <113060798+RishithaMamidala@users.noreply.github.com>
one-community
added a commit
that referenced
this pull request
Jun 12, 2025
* Newell - fix email issues (#1430) * fix(email): resolve sendEmailWithAcknowledgment promise correctly * docs(email): add JSDoc to emailSender for improved type hints and clarity * docs(email): add JSDoc to emailSender for improved type hints and clarity * fix(transaction): revert transaction edits for local debugging * Zhifan - hotfix not seeing hours logged in weekly summaries report page (#1432) * fixed logic for returning time info * fixed three weeks age tab showed no hours * Newell - move cc recipients to bcc for privacy (#1435) fix(email): move cc recipients to bcc for privacy * Strallia - Hours completed backend data (#1437) feat: get data for tangible hours percentages * Newell - add Jae to CC recipients in emailSender (#1441) feat(email): add Jae to CC recipients in emailSender * Rishitha noshow visualization metrics (#1227) * no show viz * fix url * resolve conflicts * resolve conflicts * Dharmik - fix - team code outlier and notification red (#1424) * teamCodeWarning added to userProfile * set teamcodewarning to true if the teamcode is not valid * set teamCodeWarning flag if teamcode is invalid * removed concole.logs * Rishitha create bargraph for number of issues by type backend (#1318) * issue chart backend * commit_1 * fix controller * issue chart backend * fix backend issue * Zhifan - Create way to see 6 months & yearly anniversaries (#1273) * Backend Changes for trophy functionality * changed logic to use startDate * completed follow up feature on weekly summary report * converted into CommonJS --------- Co-authored-by: Aishwarya Ramesh <arame008@odu.edu> * Nikhil - Added a unit test for bmReusableController (#1271) Added a unit test for bmReusableController.js file Co-authored-by: Nikhil Pittala <nikhilpittala7@gmail.com> * Nikhil - Added unit test for bmToolController (#1284) Added unit test for bmToolController Co-authored-by: Nikhil Pittala <nikhilpittala7@gmail.com> * Dharmik - fix/Add number of blue squares to bottom left corner of first column on User Management Page (#1410) * added infringements to getUserProfiles * fixed issues getting blue squares * Dipti create separate subscribe and unsubscribe pages linked to the app (#1418) * Update emailController.js * Update emailController.js --------- Co-authored-by: Ankuriboh <183397864+Ankuriboh@users.noreply.github.com> Co-authored-by: Zhifan Jia <127051168+mashpotato9@users.noreply.github.com> Co-authored-by: Strallia Chao <134454347+strallia@users.noreply.github.com> Co-authored-by: RishithaMamidala <113060798+RishithaMamidala@users.noreply.github.com> Co-authored-by: Dharmik1710 <47842695+Dharmik1710@users.noreply.github.com> Co-authored-by: Aishwarya Ramesh <arame008@odu.edu> Co-authored-by: nikhilpittala16 <142841075+nikhilpittala16@users.noreply.github.com> Co-authored-by: Nikhil Pittala <nikhilpittala7@gmail.com> Co-authored-by: Dipti Yadav <dipti.yadav@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix email issues