Skip to content

Zhifan - hotfix weekly email missed hours logged #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mashpotato9
Copy link
Contributor

@mashpotato9 mashpotato9 commented Jun 17, 2025

Description

Screenshot 2025-06-17 at 6 39 53 PM

Related PRS (if any):

This backend PR is not related to frontend PR.

Main changes explained:

  • Delete file A for removing unused components …
  • Update file B for including new pattern …
  • Create file C for introducing new components …

How to test:

  1. check into current branch
  2. go to https://dev.highestgood.com/dashboard then add time entry and weekly summary
  3. do npm run build and npm start to run this PR locally
  4. check console to verify the logging includes hours logged

Screenshots or videos of changes:

demo.mp4

Note:

logging will be removed once approved

@mashpotato9 mashpotato9 force-pushed the Zhifan-fix-weekly-email-missed-hours-logged branch from 53870a8 to 4004657 Compare June 17, 2025 23:35
@Venk-rgb Venk-rgb self-assigned this Jun 18, 2025
Copy link

@Venk-rgb Venk-rgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mashpotato9 . I can still only see "Hours logged: 0" for all users. Could you please double check and let me know?

PR.1467.mov

@mashpotato9
Copy link
Contributor Author

Hi @mashpotato9 . I can still only see "Hours logged: 0" for all users. Could you please double check and let me know?
PR.1467.mov

I could see my own account has hour logged that I used for testing. Here's the screen shot from you video.
Screenshot 2025-06-18 at 5 12 12 PM
I guess not many people submitted weekly summary on this dev site.

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit dfe7bc3 into development Jun 19, 2025
1 check passed
one-community added a commit that referenced this pull request Jun 19, 2025
one-community added a commit that referenced this pull request Jun 19, 2025
Revert "Zhifan - hotfix weekly email missed hours logged (#1467)"

This reverts commit dfe7bc3.
@shreyasbedekar shreyasbedekar self-requested a review June 20, 2025 23:17
@Varshakaranam18
Copy link

Screenshot 2025-06-21 at 2 51 41 PM I am not able to add project in order to test . May I know from where can I assign tasks ?

Copy link

@shreyasbedekar shreyasbedekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facing the same issue as @Varshakaranam18 not able to add my Project/Task

image

@mashpotato9 mashpotato9 added the Do Not Review Do not review or look at code without full context label Jun 22, 2025
@Charitha2009
Copy link

PR - 1467 Error There seems to be an issue when trying to log time under "Add Intangible Time." I'm unable to select the required fields — the dropdowns are either not loading or remain unresponsive. This is currently blocking me from submitting intangible hours. Please let me know if this is a known issue or if there's a workaround I can try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Review Do not review or look at code without full context
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants