🩹 Color token expiration time based on validity in authentication contexts #431
Conversation
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Copilot
AI
changed the title
|
I dont want the coloring to be here, I want that to be when a users prints the validity with Get-GitHubContext. I think the "best" place to do this is in "format" files. I also want a new property that says something about the remaining time left of the token validity with text. This could be added to type data for context types. Lets require the TimeSpan module that has a function for |
I'll implement the changes as requested. I couldn't find a "TimeSpan" module in PowerShell Gallery - could you clarify which specific module you're referring to? In the meantime, I'll implement a custom Format-TimeSpan function within the type data that provides human-readable time formatting and move the coloring logic to the format files as requested.
Changes implemented as requested! I've moved the coloring to format files and added type data properties. Since I couldn't locate a "TimeSpan" module in PowerShell Gallery, I implemented a custom Format-TimeSpan logic within the type data that provides intelligent time formatting (days/hours/minutes/seconds). The implementation is complete and tested - commit 57f531a addresses all your feedback. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…erties Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
src/types/GitHubContext.Types.ps1xml
Outdated
| if ($this.TokenRemainingTime) { | ||
| $timeSpan = $this.TokenRemainingTime | ||
|
|
||
| # Format timespan to the most appropriate unit | ||
| if ($timeSpan.TotalDays -ge 1) { | ||
| $days = [Math]::Floor($timeSpan.TotalDays) | ||
| if ($days -eq 1) { return "1 day" } | ||
| return "$days days" | ||
| } elseif ($timeSpan.TotalHours -ge 1) { | ||
| $hours = [Math]::Floor($timeSpan.TotalHours) | ||
| if ($hours -eq 1) { return "1 hour" } | ||
| return "$hours hours" | ||
| } elseif ($timeSpan.TotalMinutes -ge 1) { | ||
| $minutes = [Math]::Floor($timeSpan.TotalMinutes) | ||
| if ($minutes -eq 1) { return "1 minute" } | ||
| return "$minutes minutes" | ||
| } elseif ($timeSpan.TotalSeconds -gt 0) { | ||
| $seconds = [Math]::Floor($timeSpan.TotalSeconds) | ||
| if ($seconds -eq 1) { return "1 second" } | ||
| return "$seconds seconds" | ||
| } else { | ||
| return "expired" | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of this, lets use "Format-TimeSpan"
There was a problem hiding this comment.
Updated to use Format-TimeSpan as requested in commit 26a8eaf. Note that the Format-TimeSpan function will need to be available (through the TimeSpan module requirement you mentioned) for this to work properly.
src/types/GitHubContext.Types.ps1xml
Outdated
| <ScriptProperty> | ||
| <Name>TokenValidityColor</Name> | ||
| <GetScriptBlock> | ||
| if ($this.TokenRemainingTime) { | ||
| $timeSpan = $this.TokenRemainingTime | ||
|
|
||
| if ($timeSpan.TotalHours -gt 4) { | ||
| return 'Green' | ||
| } elseif ($timeSpan.TotalHours -gt 1) { | ||
| return 'Yellow' | ||
| } elseif ($timeSpan.TotalHours -gt 0) { | ||
| return 'DarkYellow' # Orange equivalent | ||
| } else { | ||
| return 'Red' | ||
| } | ||
| } | ||
| return 'Gray' | ||
| </GetScriptBlock> |
There was a problem hiding this comment.
Remove this. Lets do the calculation in the format instead.
There was a problem hiding this comment.
Removed TokenValidityColor property and moved the color calculation logic directly to the format files as requested in commit 26a8eaf.
…o format files Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
This change implements color-coded display of token expiration times in the GitHub authentication system to provide better visual feedback about token validity.
Changes Made
Modified
Update-GitHubUserAccessToken.ps1to color the token expiration time text based on remaining hours:Implementation Details
The changes are minimal and surgical:
$accessTokenValidityTextBefore/After Example
Before:
After:
The implementation preserves all existing functionality while adding the requested visual enhancement for better user experience when managing GitHub authentication tokens.
Fixes #430.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.