pypi: use trusted publishing for binary wheels #6543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
commented
Jul 1, 2025
Comment on lines
+147
to
+149
| repository-url: https://test.pypi.org/legacy/ | ||
| skip-existing: true | ||
| print-hash: true |
There was a problem hiding this comment.
Use kebab-case here, as snake_case is now deprecated
bjlittle
commented
Jul 1, 2025
| @@ -138,18 +142,20 @@ jobs: | |||
| name: pypi-artifacts | |||
| path: ${{ github.workspace }}/dist | |||
|
|
|||
| - uses: pypa/gh-action-pypi-publish@release/v1 | |||
| - uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc | |||
There was a problem hiding this comment.
We should be using commit SHAs for GHAs now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6543 +/- ##
=======================================
Coverage 89.89% 89.89%
=======================================
Files 90 90
Lines 24138 24138
Branches 4492 4492
=======================================
Hits 21699 21699
Misses 1679 1679
Partials 760 760 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjlittle
force-pushed
the
pypi-trusted-pub
branch
from
879b1a2 to
138b8f0
Compare
bjlittle
force-pushed
the
pypi-trusted-pub
branch
from
138b8f0 to
2559936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
PyPI now supports Trusted Publishing, which is an OIDC-based "tokenless" authentication mechanism for uploading to the index from within a CI/CD workflow.
This "tokenless" flow has significant security benefits over a traditional manually configured API token, and should be preferred wherever supported and possible.
This pull-request also requires PyPI (and Test PyPI) to be configured for Trusted Publishing for the
scitools-irisproject, which has already been performed.Reference: