Add field-level rename attribute support #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
renameattribute at the field level that takes precedence over therename_allattribute at the struct level:Also adds error propagation if you try to use an attribute not specified by
shopify_function_rust:Context:
With
serde_json,allow_b2bwas deserialised fromallowB2b, however withconvert_case, the default implementation for camelCase is to deserialise fromallowB2B, whereby it treats digits as a boundary. An alternative solution for this specific issue would be to allow for additional configuration to be passed torename_all. I'd argue that it's more flexible to keep the API simple (as it is currently), but to allow for the field levelrenameattribute.