Fix tests for ruby 3, which no longer skips C stack frames #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allocations started being done more lazily, so they wouldn't be done unnecessarily, but they are memoized. So we just need to run the block once before measuring for the test to ignore the memiozed allocations.
casperisfine
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9, ruby 3 no longer skips C stack frames, so the tests need to be updated to reflect this.
There are also now allocations that are made lazily in ruby that also need to be accounted by forcing their memoization before counting allocations in test_no_object_allocations.
Lastly, I've switched to Github Actions for CI