Fix: Improve icon contrast and text hierarchy Contributing and About Pages #4983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellecaii
changed the title
KevinMulhern
requested changes
Apr 30, 2025
| <div class="sm:col-span-10 text-center sm:text-left space-y-3"> | ||
| <h3 class="pt-10 sm:pt-0 text-lg font-semibold"> | ||
| <div class="sm:col-span-10 text-center sm:text-left"> | ||
| <h3 class="text-2xl font-semibold mb-2 text-gray-800 dark:text-white"> |
There was a problem hiding this comment.
I like most of these changes, but the font size being bigger than the section title is throwing off the hierarchy:
Suggested change
| <h3 class="text-2xl font-semibold mb-2 text-gray-800 dark:text-white"> | |
| <h3 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white"> |
| <div class="flex sm:col-span-2 justify-center "> | ||
| <%= image_tag @belief[:image_path], alt: '', class: 'w-20 h-20' %> | ||
| <div class="flex sm:col-span-2 justify-center"> | ||
| <div class="w-20 h-20 flex items-center justify-center rounded-full bg-gray-700 dark:bg-white shadow-md"> |
There was a problem hiding this comment.
The backgrounds being different from the surrounding background is drawing the eye a bit too much. You can test that by reading the belief content and noticing where your eyes want to go to. I think this will distract users from the main content.
What issues did you find with the contrast of these icons? They appear fine to me, and lighthouse isn't raising anything about em.
github-project-automation
bot
moved this from 📋 Backlog / Ideas
to 🏗 In progress
in Main Site
|
Hey @michellecaii, just checking in, do you want to finish this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The About page's belief section currently uses low-contrast icons and tight typography, especially in dark mode. This affects both accessibility and visual engagement.
This PR
Updates icon styling to use high-contrast background and foreground colors for better accessibility in both light and dark modes
Enlarges icons and wraps them in rounded backgrounds to make them more visually prominent
Improves heading size and spacing for clearer text hierarchy
Issue
Additional Information
Pull Request Requirements
keyword: brief description of changeformat, using one of the following keywords:Feature- adds new or amends existing user-facing behaviorChore- changes that have no user-facing value, refactors, dependency bumps, etcFix- bug fixesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection