Remove EOL Python code, set 3.9 as base, add 3.14 stdlib module #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflict resolved. |
|
Hi @hugovk, The script is currently failing due to a syntax error, which is preventing the It blocks inside the if statement from being parsed correctly and causing the entire test block to fail. Please resolve the check failures and sync the code with the main branch so we can proceed with the review and merge. |
|
@aparnajyothi-y Updated, please could you re-run the CI? |
priyagupta108
approved these changes
Apr 24, 2025
aparnajyothi-y
approved these changes
Apr 24, 2025
HarithaVattikuti
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2 is end-of-life and no longer supported by GitHub Actions, so remove the special handling for it.
Python 3.9 is the oldest non-EOL version, so set 3.9 as the base version.
https://devguide.python.org/versions/
Finally,
annotationlibis a new module in the 3.14 stdlib, add it.https://docs.python.org/3.14/whatsnew/3.14.html#new-modules