Handle random_seed setting at higher level in package #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #465
Changes
set_random_seed
function available to bothAutoEmulate
class andEmulator
class (and everything inheriting from it) viaConversionMixin
random_seed
in the models directly, but then I noticed with was needed for RF, so restored it there as therandom_state
is a required parameter in the actual sklearn to ensure it behaves deterministicallyrandom_seed
parameter in GP (and we might want to keep for all models), see my questions belowReviewers
A few decisions need to be made here that I'd like input on:
random_seed
into a new mixin or rename thisConversionMixin
? Assuming we want it to be available to AutoEmulate and Emulator, which we might not