#4241 Add Docker configurations #4242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Colin-de-Seroux is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
documentation
JPFrancoia
reviewed
Jun 7, 2025
readme.md
Outdated
| <summary><b>:hammer_and_wrench: Step-by-step guide for deploying on docker</b></summary> | ||
|
|
||
| 1. Fork or clone this repo as per your needs. | ||
| 2. Add `express` to the dependencies section of `package.json` |
There was a problem hiding this comment.
You can probably add this to the Dockerfile:
RUN npm install express
That way you're not adding an extra dependency to the package.json file, if this dependency is only required for the Docker deployment
There was a problem hiding this comment.
Hello, that would be more optimized. I foolishly copied the way it was done for Vercel. I'll take care of it this evening and create a new PR.
No need to add by hand express
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's of #4241.