Use new IDL package for query consistency level changes #6791
Conversation
c-warren
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| @@ -11,6 +11,26 @@ services: | |||
| interval: 15s | |||
| timeout: 30s | |||
| retries: 10 | |||
| # Setup schemas for primary and secondary clusters | |||
| cadence-schema-setup: | |||
| image: ubercadence/server:cdnc-12748 | |||
There was a problem hiding this comment.
do we have this image uploaded?
There was a problem hiding this comment.
Damn, forgot to change this one back. Will update!
docker/setup-multiclusters-schema.sh
Outdated
| @@ -0,0 +1,102 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -x | |||
There was a problem hiding this comment.
nit: set -e usually is worthwhile too, I realise this might be a copy from somewhere else, but lack of that flag is confusing usually
docker/setup-multiclusters-schema.sh
Outdated
| timeout=300 # 5 minutes timeout | ||
| counter=0 | ||
|
|
||
| while [ $counter -lt $timeout ]; do |
There was a problem hiding this comment.
nit: generally suggest preferring [[
https://google.github.io/styleguide/shellguide.html#s6.3-tests
doesn't matter overly much though
| @@ -11,6 +11,26 @@ services: | |||
| interval: 15s | |||
| timeout: 30s | |||
| retries: 10 | |||
| # Setup schemas for primary and secondary clusters | |||
There was a problem hiding this comment.
Thanks for fixing this specific multicluster compose setup. We also have a new replication simulation with to test various scenarios in 2 cluster environment. It would be great to enhance it to validate the new strong consistency APIs. Ref: #7007
What changed?
cadence-idlhas been updated to support specifying QueryConsistencyLevel on theGetWorkflowExecutionHistoryandDescribeWorkflowrpcs. This PR pulls in those changes and adds support for the new fields to the mapper functions for thrift and proto.Why?
This finishes piping data from a request through to the implementation to support specifying a queryconsistencylevel in the frontend. Client updates are still required for consumers to use the fields.
How did you test it?
Updated unit tests to validate the mapper functions.
To sanity check with integration tests:
Potential risks
Serialization failures on inbound requests on the DescribeWorkflowExecution or GetWorkflowExecutionHistory requests.
Release notes
cadence-frontendnow supports passing a QueryConsistencyLevel to DescribeWorkflowExecution and GetWorkflowExecutionHistory rpcs.Documentation Changes
N/A