Skip to content

Mandychen/migrate buildkite to GitHub actions #6946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 63 commits into
base: master
Choose a base branch
from

Conversation

mandyschen
Copy link

What changed?
Added Github Actions implementation to buildkite pipeline pipeline-master.yml

Why?
To keep all the pipelines in the same place

How did you test it?
Ran the pipeline through my own commits. Plan to test on different commits and compare outcomes with prior buildkite pipeline

Potential risks
Some issues aren't caught because they weren't caught in the pipeline. Some good PRs cant be merged because they were falsely caught by the pipeline

Release notes

Documentation Changes

@mandyschen
Copy link
Author

The CI failed. Looks like it might be an issue related to the Docker path.

@bowenxia After I reran it it seems like it fixed itself. I think it might have been a timing issue where Cassandra was not fully done initializing before the next command ran so it ran into a path not found error?

I never ran into any issues with tests failing in GitHub Actions except for in the unit test when running make cover_profile so thats the only command with an automatic retry. I'll add retries to the rest of the commands just to cover all the bases since that's what the buildkite version does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants