fix(): add guard to ensure that elements are not null to prevent null… #4386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reference in boundingRect call
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-call-boundingrect-of-null |
mfranzke
previously approved these changes
Jun 16, 2025
|
@nmerget I like this solution, but your opinion on this as well. |
mfranzke
approved these changes
Jun 17, 2025
auto-merge was automatically disabled
June 17, 2025 07:03
Pull Request is not mergeable
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #4373
Types of changes
Further comments