feat: Add disassembler support for macos #2781
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You tested it? The issues on ClrMD are still open. microsoft/clrmd#1034 microsoft/clrmd#1230 |
|
I've not noticed issues listed above. I confirmed only And I'm only confirmed unit tests passed on CI. (Because I'm not have mac) |
filzrev
commented
Jun 15, 2025
| @@ -37,19 +37,11 @@ public static IEnumerable<object[]> GetAllJits() | |||
| { | |||
| yield return new object[] { Jit.RyuJit, Platform.X64, CoreRuntime.Core80 }; // .NET Core x64 | |||
| } | |||
| else if (RuntimeInformation.GetCurrentPlatform() is Platform.Arm64 && OsDetector.IsLinux()) | |||
| else if (RuntimeInformation.GetCurrentPlatform() is Platform.Arm64) | |||
There was a problem hiding this comment.
Note: This changes affects windows-11-arm tests also.
|
It would be helpful if someone could confirm DisassemblyDiagnoser's behaviors with an actual mac device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to add DisassemblyDiagnoser supports for macos.
Currently DisassemblyDiagnoser is not supported on macos.
This limitation appears to be coming from the ClrMD library.
And It seems to be resolved in the latest version.