You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fixup! release: create initial Windows installer build workflow
I almost made the mistake of releasing v2.41.0.vfs.1.0 (where I chose
the "1" to indicate that it is based on a newer Git for Windows version
than v2.41.0.vfs.0.0, namely based on v2.41.0.windows.2).
This would have broken VFS for Git, though. The code comments at
https://github.com/microsoft/VFSForGit/blob/3790eb06e14d/Version.props#L7-L22
and
https://github.com/microsoft/VFSForGit/blob/3790eb06e14d/GVFS/GVFS/CommandLine/GVFSVerb.cs#L901-L908
clearly state:
Note that we require that the revision (Z) of the Git version
string (2.X.Y.vfs.Z.W) is an exact match.
[...]
<MinimumGitVersion>v2.31.0.vfs.0.1</MinimumGitVersion>
To make sure that I cannot make that mistake anymore, let's validate the
tag format to the stringent pattern that is actually required to make
VFS for Git work as intended.
Helped-by: Matthew John Cheetham <mjcheetham@outlook.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
0 commit comments