feat: add urllib4 fetch #5424
feat: add urllib4 fetch #5424
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @killagu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates the modern fetch API provided by urllib4 into the application framework. It's designed to be forward-compatible, activating this new functionality only when running on Node.js 18 or newer, thereby enhancing the application's HTTP client capabilities for modern environments without breaking existing setups.
Highlights
- New Feature:
urllib4Fetch API: Introduced thefetchAPI functionality fromurllib4, providing a modern way to make HTTP requests within the application. - Conditional Node.js Version Support: The
urllib4integration is conditionally enabled only for Node.js environments running version 18 or higher, ensuring compatibility with older Node.js versions while leveraging newer capabilities. - Application Instance Exposure: The
FetchFactoryandfetchfunction are now exposed directly on theappinstance (e.g.,app.fetch), making them easily accessible throughout the application. - New Test Coverage: Added dedicated unit tests for the
fetch_factorymodule to verify the correct functionality of theurllib4fetchintegration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Deploying egg-v3 with
|
| Latest commit: |
ab5b5bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d404f25.egg-v3.pages.dev |
| Branch Preview URL: | https://feat-fetch.egg-v3.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request introduces urllib4's fetch capabilities to the application, providing a modern alternative for making HTTP requests. The changes include updating type definitions, conditionally loading urllib4 based on the Node.js version, and integrating the FetchFactory and fetch methods into the EggApplication class. My review identified a few areas for improvement related to maintainability, configuration, and crucially, security, specifically regarding SSRF protection for the new fetch API.
| @@ -51,6 +52,11 @@ class EggApplication extends EggCore { | |||
| this.ContextHttpClient = ContextHttpClient; | |||
| this.HttpClient = HttpClient; | |||
| this.HttpClientNext = HttpClientNext; | |||
| this.FetchFactory = FetchFactory; | |||
| if (FetchFactory) { | |||
| this.FetchFactory.setClientOptions(); | |||
There was a problem hiding this comment.
The FetchFactory.setClientOptions() method is called without any arguments. In lib/core/httpclient.js and lib/core/httpclient_next.js, HttpClient and HttpClientNext are initialized with app.config.httpclient to apply global HTTP client settings (like timeouts, keep-alive agents, etc.). It's highly probable that FetchFactory also needs to be configured with these settings to ensure fetch requests behave consistently with other HTTP requests in the application. Without proper configuration, fetch might not respect the configured timeouts, agents, or other crucial settings, leading to unexpected behavior or performance issues.
| this.FetchFactory.setClientOptions(); | |
| this.FetchFactory.setClientOptions(this.config.httpclient); |
Deploying egg with
|
| Latest commit: |
ab5b5bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0173dc80.egg-cci.pages.dev |
| Branch Preview URL: | https://feat-fetch.egg-cci.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #5424 +/- ##
==========================================
- Coverage 99.69% 99.58% -0.11%
==========================================
Files 35 36 +1
Lines 3609 3653 +44
Branches 538 544 +6
==========================================
+ Hits 3598 3638 +40
- Misses 11 15 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@killagu 改成 3.x 分支，我忘记将 master 删除了 https://github.com/eggjs/egg/tree/3.x |
- add v3 link to nav menu - remove vercel config
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
[skip ci] ## [3.31.0](v3.30.1...v3.31.0) (2025-07-04) ### Features * add urllib4 fetch ([#5424](#5424)) ([63d14da](63d14da))
No description provided.