[GHSA-4www-5p9h-95mh] http-proxy-middleware can call writeBody twice because "else if" is not used #5486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- advisories/github-reviewed/2025/04/GHSA-4www-5p9h-95mh/GHSA-4www-5p9h-95mh.json: Language not supported
github-actions
bot
changed the base branch from
main
to
sealonohana/advisory-improvement-5486
advisory-database
bot
merged commit 182c226
into
sealonohana/advisory-improvement-5486
4 checks passed
|
Hi @sealonohana! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
CVE-2025-32996 is not applicable until 1.3.0. The CVE relates to a function called
fixRequestBodywhich takes the request body and makes sure that the request body is written in the right format. For example - if thecontent-typeis JSON - it will write the body as a JSON. If it ismultipart/form-datait will write the body is form-data. The vulnerability allows to write the body as both JSON and form-data and lead to exploits. The functionality offixRequestBodywas not existed until 1.3.0.The code was added in v1.3.0:
https://github.com/chimurai/http-proxy-middleware/tree/v1.3.0/src/handlers
In the following Pull Request:
chimurai/http-proxy-middleware#492