-
Notifications
You must be signed in to change notification settings - Fork 1.7k
codeql resolve qlpacks
is reporting errors for duplicated packs from different languages even though it is not a problem
#17059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @RobbingDaHood 👋 Thanks for flagging this up. I can confirm that this happens for me as well when I download the CLI and run I am checking with the relevant team to see if this is intentional behaviour. Are you running into any further issues or is it just the output of the command that's unexpected? |
Hi @mbg Thx for the quick response. I did try to create and analyze a database on a java project and it behaved as expected (As far as I could see) so there does not seem to be a problem with resolving what pack to use: As the errors suggest. So in short: Nope, I have not seen any other issues as a result of this. |
PS: I did not go in depth of the analysis on the java project investigating if it did in fact apply the packs that were flagged as being duplicated. I could try to look more into that. There is a risk that they are not applied as the errors states. |
Thanks for confirming that! It seems that the team is aware that the output of |
Suggestion So maybe the resolve command should not consider anything in this subpath? Other issues? But at least it is not confirmed to be an issue :) The command seems nice The resolve command is quite neat to verify the codeql configuration, so would it not be nice to keep it and just improve it a bit? |
@mbg I took a look around the repo and could not see where the |
@RobbingDaHood the implementation of the CLI is not open source. |
I'm facing the same issue on ubuntu 22.04 |
Description of the issue
A fresh download of the CodeQL bundle shows errors when running:
The errors shown seems to be false positives because they all seems to report duplicated packs: But the packs are in separate languages, so it could be fine: If that is the case, then the
resolve qlpacks
likely just need to consider if the packs are in fact from different languages.On the other hand, then it does seem strange that multiple languages have individual packs for
xml
,yml
etc. Should they not all be defined in one location? And if there then are language specific considerations for these cases then they could be added in the relevant language folder.Reproduction
./codeql resolve qlpacks
at the root of the unpacked folder.Here is the full output of my run
The text was updated successfully, but these errors were encountered: