Skip to content

Java: Improve ImportStaticTypeMember and ImportStaticOnDemand #10497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Marcono1234
Copy link
Contributor

  • ImportStaticTypeMember and ImportStaticOnDemand are now properly considering inherited members (except for inherited member types, see Java: RefType.inherits(Member) does not work for member types #5596).
  • ImportStaticOnDemand predicates do not have non-static members and initializer methods as results anymore.
  • ImportOnDemandFromPackage.getAnImport() does not have nested types as result anymore.

not enclInReftype(this, _) and
(this instanceof Class or this instanceof Interface)
}
class TopLevelType extends ClassOrInterface {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be functionally equivalent.

Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants