Skip to content

Go: Use any() to stub getCallbackParameter/ReturnType #11125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Go: Use any() to stub getCallbackParameter/ReturnType #11125

wants to merge 1 commit into from

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Nov 4, 2022

This is used in all other languages not currently using dataflow type pruning.

@smowton
Use any() to stub getCallbackParameter/ReturnType
11c6b4f 
This is used in all other languages not currently using dataflow type pruning.
@smowton smowton requested a review from a team as a code owner November 4, 2022 13:20
@github-actions github-actions bot added the Go label Nov 4, 2022
aschackmull
aschackmull approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume DataFlowType is singleton? If so, this LGTM.

@smowton
Copy link
Contributor Author

smowton commented Nov 4, 2022

It is not: class DataFlowType = Type; -- whereas I note other languages use a singleton that don't do type pruning.

aschackmull
aschackmull requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this change won't work - you're introducing huge cartesian products by assigning all types to synthesised nodes related to callbacks.

@smowton
Copy link
Contributor Author

smowton commented Nov 7, 2022

ok, I hadn't looked in detail -- assumed because other languages were stubbing using any() it must be e.g. a type-pruning filter. I'll take a look at whether we should use a singleton DataFlowType if we're not providing type pruning at all.

@owen-mc owen-mc changed the title Use any() to stub getCallbackParameter/ReturnType Go: Use any() to stub getCallbackParameter/ReturnType Dec 7, 2022
@owen-mc owen-mc mentioned this pull request Dec 15, 2022
Merged
@smowton
Copy link
Contributor Author

smowton commented Dec 19, 2022

Replaced by #11706

@smowton smowton closed this Dec 19, 2022
@owen-mc owen-mc deleted the smowton/fix/go-callback-type-stubs branch December 19, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull

Assignees
No one assigned
Labels
Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smowton @aschackmull