LGTM deprecation: Update basic queries to use VS Code

[felicitymay]

This pull request updates the basic query introduction articles to use VS Code in pace of LGTM.com's query console. This is a replacement for: #11423.

Please tick the list below to confirm that your team is happy with the changes.

• C/C++ article
• C# article
• Go article
• Java article
• JavaScript article
• Python article
• Ruby article

The general approach was reviewed and agreed in: #11423.

For an HTML preview of the resulting docs, look at the Docs - Generate Sphinx check. You should find an artefact that you can download, so you can view the HTML generated from the rst files.

[jketema]

C++ generally looks good to me. One question.

[atorralba]

Java LGTM 👍

[atorralba]

Actually, one minor thing.

[aibaars]

Ruby 👍

[smowton]

Go 👍

[erik-krogh]

JS 👍

[yoff]

Generally quite nice, only one typo.
I wonder if we should find a smaller DB than saltstack/salt, but on the other hand it is nice to see a bunch of results and then a small bunch of results after refining the query..

[felicitymay]

👋🏻 I believe that I've applied all changes. I'm planning to merge this PR before I stop work at the end of my (UK) day.

[SiaraMist]

LGTM! 🚀

[yoff]

👋🏻 I believe that I've applied all changes. I'm planning to merge this PR before I stop work at the end of my (UK) day.

I checked a few times, but you must have done it later. What I would normally expect is that you re-request a review from me (in the top right reviewers panel) and then I get notified and can approve your changes. Then you do not have to merge in the "changes requested" state :-)

[felicitymay]

I checked a few times, but you must have done it later. What I would normally expect is that you re-request a review from me (in the top right reviewers panel) and then I get notified and can approve your changes. Then you do not have to merge in the "changes requested" state :-)

Hi @yoff. Thanks for letting me know the expected etiquette for this situation, it's much appreciated. We rarely use that feature in the repositories I usually work in and I overlooked it. If there are changes that I missed, or you have feedback on the changes I made, please do go ahead and add them here. I'd be happy to open a new PR with any corrections.

[yoff]

If there are changes that I missed, or you have feedback on the changes I made, please do go ahead and add them here. I'd be happy to open a new PR with any corrections.

I think all my comments are addressed appropriately 👍