JS: only set the file in the diagnostics message if the file is within the source root #12742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional content flow through constructors remains.
Again, this is hacky; we don't distinguish rigorously between an optional value and its content (similar to how it was before enum content flow).
…eorder Ruby: Order synthetic children in PrintAST based on their index instead of location
…-data Java: Docs MaD using extensions.
…direct-type-inference python: Fix link to type inference
…-binary C#: Improve cs/web/debug-binary to repect the RemoveAttributes transformation.
python: port `py/comparison-using-is`
…l-namespace RB: always resolve toplevel namespaces to their locally qualified name
…for-javascript.rst Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
…in-use` Notice that it doesn't find the potentially unsafe version, or the vuln that spans calls.
…-java-libs-to-dataflow-modules Java: Refactor Java query libraries to use dataflow modules
…-call-to-strncat C++: Fix join order in `cpp/unsafe-strncat`
…ly-extracted-lines Swift: add `SuccessfullyExtractedLines` query
QL: Make Class.getType() only return ClassType
JS: Fix qhelp after file rename
aibaars
requested changes
Apr 3, 2023
henrymercer
reviewed
Apr 3, 2023
| if (file.startsWith(LGTM_SRC)) { | ||
| relativeFilePath = file.subpath(LGTM_SRC.getNameCount(), file.getNameCount()).toString(); | ||
| builder = builder.setFile(file.subpath(LGTM_SRC.getNameCount(), file.getNameCount()).toString()); |
There was a problem hiding this comment.
Should we skip diagnostics, or perhaps just diagnostic locations, for files outside the source root? I'm not sure how useful it is to have a location with a range but without a file path.
|
Sorry for the ping, bad change of branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #12734
I wasn't able to replicate locally, but the stack-trace in the issue provided enough information.
It was this change that caused the null-pointer: #12113 (comment)