Swift: add CFG and PrintAst consistency queries, enabling them in CI #13270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
requested changes
May 24, 2023
| @@ -0,0 +1 @@ | |||
| import codeql.swift.printast.Consistency | |||
There was a problem hiding this comment.
I think we should not include these queries in the codeql/swift-queries pack. They are not meant for users. Other languages seem to store them in separate packs LANG/ql/consistency-queries.
Previously there was code that was treating `BraceStmt` within `TapExpr` in a special way, skipping the first variable declaration element which was purposedly visited first in the `TapExpr` itself. This might have introduced CFG inconsistencies, and here this is switched to a simpler setup where the tap expression variable declaration is visited in the body as is normal for `BraceStmt`.
|
I discussed a plan with @MathiasVP:
The current status of this PR is highly incomplete, also the fix to the property wrapper double needs to be revisited, as it turns out the initializer is not always shared between a var decl and its synthesized property wrapper backing binding. |
MathiasVP
reviewed
May 24, 2023
| @@ -969,6 +959,9 @@ module Decls { | |||
| result.asAstNode() = ast.getPattern(j).getFullyUnresolved() | |||
| ) | |||
| or | |||
| // PropertyWrapperBackingVarBinding is a special case as it shares the init | |||
| // with the original variable binding (see also PrintAstNode.qll) | |||
| ast != any(VarDecl d).getPropertyWrapperBackingVarBinding() and | |||
There was a problem hiding this comment.
As we discussed in our sync. See https://codeql.github.com/docs/ql-language-reference/formulas/#equality.
Suggested change
| ast != any(VarDecl d).getPropertyWrapperBackingVarBinding() and | |
| not ast = any(VarDecl d).getPropertyWrapperBackingVarBinding() and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.