Skip to content

Go: Remove Unique from TypeParamTable #17413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 9, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).

@mbg mbg self-assigned this Sep 9, 2024
@github-actions github-actions bot added the Go label Sep 9, 2024
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tp should be unique; it is the master key of the table. The same type parameter having multiple conflicting names, bounds, or parents is an error.

@mbg mbg closed this Sep 9, 2024
@mbg mbg deleted the mbg/go/fix-anon-type-params branch September 9, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants