Skip to content

Go: Support more dependency managers in IsGolangVendorDirectory #18929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

mbg
Copy link
Member

@mbg mbg commented Mar 5, 2025

No description provided.

@mbg mbg self-assigned this Mar 5, 2025
@Copilot Copilot AI review requested due to automatic review settings March 5, 2025 00:19
@mbg mbg requested a review from a team as a code owner March 5, 2025 00:19
@github-actions github-actions bot added the Go label Mar 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request enhances the IsGolangVendorDirectory function to support additional dependency managers by checking for extra files.

  • Added support for Gopkg.lock and vendor.conf detection
  • Maintained existing checks for modules.txt and glide.yaml

Reviewed Changes

File Description
go/extractor/util/util.go Updated IsGolangVendorDirectory to support additional dependency managers

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is good. Retarget to rc/3.17 so it gets into the next release.

@mbg mbg changed the base branch from main to rc/3.17 March 6, 2025 15:38
@mbg mbg requested review from a team as code owners March 6, 2025 15:38
@mbg mbg marked this pull request as draft March 6, 2025 15:38
@mbg mbg force-pushed the mbg/go/filter-more-vendor-dirs branch from c47bad2 to b872c60 Compare March 6, 2025 15:40
@mbg mbg removed request for a team March 6, 2025 15:41
@mbg mbg marked this pull request as ready for review March 6, 2025 15:41
@mbg mbg requested a review from owen-mc March 6, 2025 15:41
@mbg mbg merged commit 16e84d0 into rc/3.17 Mar 6, 2025
10 checks passed
@mbg mbg deleted the mbg/go/filter-more-vendor-dirs branch March 6, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants