Skip to content

Rust: do not remove Cargo.lock file when running QL tests #19803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

redsun82
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 15:11
@redsun82 redsun82 requested a review from a team as a code owner June 17, 2025 15:11
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jun 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR stops deleting the Cargo.lock file when preparing QL tests by removing the helper function and its invocation.

  • Removed the remove_file_if_exists helper and its call in prepare().
  • Dropped the now-unused std::path::Path import.
Comments suppressed due to low confidence (1)

rust/extractor/src/qltest.rs:64

  • Consider adding a test to verify that Cargo.lock remains intact after running prepare(), ensuring this change is covered by your test suite.
    set_sources(config)?;

@redsun82 redsun82 merged commit b2f7b89 into main Jun 17, 2025
14 checks passed
@redsun82 redsun82 deleted the redsun82/rust-fix-qltest-lock-file branch June 17, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants